Closed stevechoy closed 1 day ago
The logic of how binning is handled for median lines are wrong.
Previously, increments are defined as follows:
bin_increment <- max_data_x / bin_number bin_times <- seq(min_data_x, max_data_x, by = bin_increment)
bin_increment <- max_data_x / bin_number
bin_times <- seq(min_data_x, max_data_x, by = bin_increment)
This is problematic when the min_data_x is sufficiently close to max_data_x, leading to too few bin_times.
min_data_x
max_data_x
bin_times
To actually get 20 bins (bin_number default), bin_increment needs to be corrected to: bin_increment <- (max_data_x - min_data_x) / bin_number
bin_number
bin_increment
bin_increment <- (max_data_x - min_data_x) / bin_number
This is now fixed and will be implemented for v0.2.9.
The logic of how binning is handled for median lines are wrong.
Previously, increments are defined as follows:
bin_increment <- max_data_x / bin_number
bin_times <- seq(min_data_x, max_data_x, by = bin_increment)
This is problematic when the
min_data_x
is sufficiently close tomax_data_x
, leading to too fewbin_times
.To actually get 20 bins (
bin_number
default),bin_increment
needs to be corrected to:bin_increment <- (max_data_x - min_data_x) / bin_number