Boeing / config-file-validator

Cross Platform tool to validate configuration files
https://boeing.github.io/config-file-validator/
Apache License 2.0
324 stars 55 forks source link

Quiet Flag For CLI #124

Closed HakanVardarr closed 6 months ago

HakanVardarr commented 6 months ago

tried to implement quiet flag. Added a global variable Quiet and WithQuiet function in cli.go. I forgot to remove the env implementation. I took the easy way with the global variable if you don't like it I can try to find another way.

Closed #105

kehoecj commented 6 months ago

Thanks for another PR @HakanVardarr ! Can you take out the env changes so this is a standalone PR?

HakanVardarr commented 6 months ago

@kehoecj I am new to pull request stuff sorry for the mistake. I am trying to learn. :)

kehoecj commented 6 months ago

@kehoecj I am new to pull request stuff sorry for the mistake. I am trying to learn. :)

No problem at all! Glad to have you contributing

HakanVardarr commented 6 months ago

@kehoecj I'll look for thath issue

HakanVardarr commented 6 months ago

You didn't pass the quiet flag in the test

 docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
 docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test

I ran this and I didn't get any output.

Screenshot 2024-03-29 at 21 17 42
kehoecj commented 6 months ago

You didn't pass the quiet flag in the test

 docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test

I ran this and I didn't get any output. Screenshot 2024-03-29 at 21 17 42

You're right! The container name threw me off. I re-ran with --quiet and it works as expected. Thanks for QA-ing my QA 😆

HakanVardarr commented 6 months ago

You didn't pass the quiet flag in the test

 docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test

I ran this and I didn't get any output. Screenshot 2024-03-29 at 21 17 42

You're right! The container name threw me off. I re-ran with --quiet and it works as expected. Thanks for QA-ing my QA 😆

If it is working that is good. 😄

ccoVeille commented 6 months ago

Thanks a lot for implementing the quiet mode