Closed HakanVardarr closed 6 months ago
Thanks for another PR @HakanVardarr ! Can you take out the env changes so this is a standalone PR?
@kehoecj I am new to pull request stuff sorry for the mistake. I am trying to learn. :)
@kehoecj I am new to pull request stuff sorry for the mistake. I am trying to learn. :)
No problem at all! Glad to have you contributing
@kehoecj I'll look for thath issue
You didn't pass the quiet flag in the test
docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test
I ran this and I didn't get any output.
You didn't pass the quiet flag in the test
docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test
I ran this and I didn't get any output.
You're right! The container name threw me off. I re-ran with --quiet
and it works as expected. Thanks for QA-ing my QA 😆
You didn't pass the quiet flag in the test
docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test
I ran this and I didn't get any output.
You're right! The container name threw me off. I re-ran with
--quiet
and it works as expected. Thanks for QA-ing my QA 😆
If it is working that is good. 😄
Thanks a lot for implementing the quiet mode
tried to implement quiet flag. Added a global variable Quiet and WithQuiet function in cli.go. I forgot to remove the env implementation. I took the easy way with the global variable if you don't like it I can try to find another way.
Closed #105