Bogardo / Mailgun

Mailgun package for Laravel
MIT License
295 stars 115 forks source link

Suggestion add api()->get() example to readme #116

Open ddeath opened 7 years ago

ddeath commented 7 years ago

Hi there,

I would like to suggest to add api()->get() request, which needs domain, to readme as example. For example:

Mailgun::api()->get('my-domain/tags');

I was assuming that it will be added by library because I specified domain in config file. But it is not case. Also for example call:

Mailgun::api()->get('/tags');

returns:

{#880
 +"http_response_body": "Mailgun Magnificent API",
 +"http_response_code": 200,
}

It took me some time to figure it out :) Maybe it will save some time to others :)

I know that it is my fault because in the mailgun api is written endpoint as 'domain/tags' and I made wrong implication that setting domain in config file is sufficient...

newdygo commented 7 years ago

Thanks man, you help a lot.