search

Bogardo / Mailgun

Mailgun package for Laravel
MIT License
295 stars 115 forks source link

Update nesbot/carbon dependency #148

Open grenadecx opened 6 years ago

grenadecx commented 6 years ago

Is it possible to update the nesbot/carbon dependency for this project?

I'm not sure of the implications, but I took a quick look through the project and it seems that it would be fine to update it, from what I can tell, the newer carbon versions have the same api that is being used here.

I would greatly appreciate it anyways, since newer nesbot/carbon have a lot more useful features.

Updating to either 1.32 or even to 2.1.0 would be awesome. The only downside I found is that nesbot/carbon 2.0 requires higher version of php, but I guess that could easily be solved by setting a requirement to something like >=1.21.0 <=2.1.0.

https://github.com/briannesbitt/Carbon/issues/1435

connecteev commented 5 years ago

+1 This doesn't work with Laravel 5.8 without nesbot/carbon v 2.19