search

Bogdan-Lyashenko / codecrumbs

Learn, design or document codebase by putting breadcrumbs in source code. Live updates, multi-language support and more.
https://codecrumbs.io
BSD 3-Clause "New" or "Revised" License
2.71k stars 101 forks source link

suggestion: use styled-components for styling #7

Open ghsamm opened 5 years ago

ghsamm commented 5 years ago

I have been using styled-components for a while now and I think it's the best tool for styling React components.

I have even prepared a presentation about styled-components, check it out: https://paper.dropbox.com/doc/Go-My-Code-webinars-styled-components-with-Sam--AV03sRyI~PeudxfaYB~7nOYwAQ-QAt6W9GiJlN6U06ExXVey

what do you think ?

Bogdan-Lyashenko commented 5 years ago

@ghsamm, thanks for bringing this, you may be right. When it was the last time I worked with styled-components Webstorm (code editor I use) had no support for syntax highlight/autocomplete (because it's string), that was a main thing I didn't like. Also, since half of CSS in codecrumbs are styles for SVG I want to have it as pure as possible, because of performance concerns (SVG tree can be super big for big codebase). Anyway, let's keep this issue open, we might migrate to styled-components later when see it brings benefits or next time we do major refactoring, right now it's just too much hight prio work to be done apart of styled-components 😸

popuguytheparrot commented 5 years ago

В webstorm есть плагин. Называется styled-components. Добавляет автокомплит и все такое