search

Bogdanp / django_dramatiq

A Django app that integrates with Dramatiq.
https://dramatiq.io
Other
331 stars 77 forks source link

Middleware naming inconsistency #13

Closed rpkilby closed 5 years ago

rpkilby commented 6 years ago

Just a thought. The builtin dramatiq middleware do not have the Middleware suffix, so it's slightly inconsistent that the drango_dramatiq middleware do have the suffix. Maybe..

Bogdanp commented 6 years ago

I struggled with this initially while thinking about whether or not to use the suffixes. I went with the suffixed naming because I figured that was more common in the world of Django. May be worth revisiting in a future release though so I'll keep this open.

Bogdanp commented 5 years ago

I'm closing this as I don't think this is worth making a breaking change for.