Bogdanp / django_dramatiq

A Django app that integrates with Dramatiq.
https://dramatiq.io
Other
331 stars 77 forks source link

doc: split magic numbers #139

Closed jnns closed 1 year ago

jnns commented 1 year ago

In dramatiq, DEFAULT_RESULT_TTL = 600_000 which is documented as the 10 minute default. In django_dramatiq, the example uses "result_ttl": 60_000 which equates to 1 minute. Although the example shows a customization and not necessarily the defaults, the duration is better communicated by splitting it up into different units.

Maybe it's just me, but I wasn't sure which units the durations had to be specified in and had to look at the source code / docs.