Bogdanp / django_dramatiq

A Django app that integrates with Dramatiq.
https://dramatiq.io
Other
331 stars 77 forks source link

Use update_or_create instead of custom implementation #23

Closed aericson closed 5 years ago

aericson commented 5 years ago

I think we should use Django's update_or_create. The current implementation does not use select_for_update and does not wrap queries into a transaction and other corner cases that Django already handle with tested code.

Bogdanp commented 5 years ago

Thanks! I merged and released these changes with rebase in 0.5.1