search

Bogdanp / django_dramatiq

A Django app that integrates with Dramatiq.
https://dramatiq.io
Other
347 stars 77 forks source link

rundramatiq --no-reload default #41

Closed ramonsaraiva closed 4 years ago

ramonsaraiva commented 5 years ago

Since watch is an optional dependency, doesn't it make more sense to have --watch not included by default on rundramatiq instead of needing to manually disable auto-reload with --no-reload?

Right now, installing dramatiq without [watch] and running rundramatiq ends up erroing.

If you think that's a better approach, I wouldn't mind patching it.

Bogdanp commented 5 years ago

Yes, I'd accept this change. I think I wanted things to work the same as the runserver command out of the box, but I can see how it can be bad UX from the perspective of someone who has installed dramatiq w/o the watch extras.

ramonsaraiva commented 5 years ago

Cool, I'll be creating a PR this week.

Bogdanp commented 4 years ago

This change was released a while back but I forgot to close the issue. Thanks again for your help!