search

Bogdanp / django_dramatiq

A Django app that integrates with Dramatiq.
https://dramatiq.io
Other
347 stars 77 forks source link

rundramatiq --reload instead of --no-reload #42

Closed ramonsaraiva closed 5 years ago

ramonsaraiva commented 5 years ago

fixes #41

Bogdanp commented 5 years ago

Thanks! I'll merge and release this towards the end of the week.

ramonsaraiva commented 5 years ago

@Bogdanp should I also add an optional path parameter to --reload? Seems like it is strict to . right now, cause it simply adds --watch .

Bogdanp commented 5 years ago

@ramonsaraiva yes, please do.

Bogdanp commented 5 years ago

@ramonsaraiva are you still interested in adding the optional path parameter? Otherwise, I can just merge this as-is and release it.

ramonsaraiva commented 5 years ago

Im in South Africa in a vacation trip. I would suggest merging this one and I’ll add the optional path parameter in a follow-up.

On Mon, 22 Jul 2019 at 16:28 Bogdan Popa notifications@github.com wrote:

@ramonsaraiva https://github.com/ramonsaraiva are you still interested in adding the optional path parameter? Otherwise, I can just merge this as-is and release it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bogdanp/django_dramatiq/pull/42?email_source=notifications&email_token=ABKNGUHIKPTTZFMLR5BRE3TQAW7XJA5CNFSM4H22GYU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2QDFPI#issuecomment-513815229, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKNGUHEABWLL6RAG5G7673QAW7XJANCNFSM4H22GYUQ .

Bogdanp commented 5 years ago

Thanks, this is now in master. I'll release it sometime in the coming weeks.