Add positional information

[baransu]

Huge thanks to @joeandaverde for creating most of what is implemented in this PR in the first place. Also shoutout to the @laslowh who helped with rest of the types. You're the best!!! 🎉

All Expressions and Statements now have Meta as last argument { line: Int, column: Int }. Positional information are not perfect. There as some cases where whitespaces are omitted in column count but besides everything works as expected.

This is big breaking change and I'm counting on your feedback.

Fixes: #13

---

Almost all types are converted contain meta information except:

• [x] TypeApplication
• [x] Application
• [x] BinOp
• [x] Variable

They are advanced because of

• partial application in case of TypeApplication and Application
• creating in place Variable and BinOp types

~I was trying implement Meta for those as well but I've failed lacking knowledge and full understanding of parser-combinators as well as advanced Elm. That why I'm creating this WIP PR, counting on your support.~~

[baransu]

Support for all types has arrived!!! 🎉

Huge shoutout to @joeandaverde and @laslowh for their work on making this changes possible. This is huge breaking change and I'm looking forward on any feedback.

[collosi]

Just checking in on this. Has any progress on the line numbering bug been made?

[wende]

@laslowh So the issue is with lines starting from index 0 (rather than 1) then jumping straight to 2, and treating the last line in the expression as the same as one before. So essentially instead of getting 1,2,3,4,5, we're getting 0,2,3,4,4. No idea what's the cause Could use a little work on that. I might try to take a look this weekend

CC. @Baransu

[dynajoe]

Looks like the line numbering issues were addressed:

https://github.com/elm-community/parser-combinators/blob/master/CHANGELOG.md

I've started work on fixing the tests and upgrading the package. https://github.com/Baransu/elm-ast/pull/2

[paulsonnentag]

Is this PR still active? If not could I help getting this feature merged?

[wende]

@paulsonnentag there's nobody actively working on this. It'd be great if you tried your shot

[paulsonnentag]

@joeandaverde I've checked out your latest commit, but it seems like there are still a lot of cases where the line/column number is not correct. Do you have any tips on what the problem could be? Otherwise, I'll have to dig deeper into the code.

[wende]

I've started working on this issue this weekend and it looks like it will see a closure soon

[baransu]

@wende If you need any help, let me know 😃

[wende]

Closed in favour of #99