search

Bogdanp / racket-gui-easy

Declarative GUIs in Racket.
https://docs.racket-lang.org/gui-easy/index.html
134 stars 18 forks source link

correct defmixin domain #32

Closed benknoble closed 1 year ago

benknoble commented 1 year ago

According to the documentation, the domain-ids should be classes or interfaces with documentation, not predicates. Since this mixin accepts any object, object% is the appropriate domain.

This should hopefully fix the following warning, too:

2023-01-25T16:05:33.3192826Z raco setup: WARNING: undefined tag in <pkgs>/gui-easy/gui/easy/scribblings/gui-easy.scrbl:
2023-01-25T16:05:33.3193800Z raco setup:  (cls/intf ((lib "racket/private/class-internal.rkt") class?))
Bogdanp commented 1 year ago

Thanks!

benknoble commented 1 year ago

Well, this still produces

raco setup: WARNING: undefined tag in <pkgs>/gui-easy/gui/easy/scribblings/gui-easy.scrbl:
raco setup:  (cls/intf ((lib "racket/private/class-internal.rkt") object%))

which I don't understand, since I'm pretty sure I saw (require (for-label racket/class)) in there, and the link to object% in my local docs still works (despite the warning).

@samth, this tag looks odd given the private/class-internal reference; any thoughts?

samth commented 1 year ago

The private/class-internal is just the module that it's originally defined in. My guess is that it's some other reference to object% somewhere in the docs.

benknoble commented 1 year ago

My guess is that it's some other reference to object% somewhere in the docs.

Even though the reference original said class? and, after changing the use of class? to object% the error message changed accordingly?