Checking for unused requires?

Bogdanp / racket-review

A linter for Racket.

BSD 3-Clause "New" or "Revised" License

41 stars 4 forks source link

Checking for unused requires? #1

Open jackfirth opened 4 years ago

jackfirth commented 4 years ago

Can this also check for unnecessarily required modules?

Bogdanp commented 4 years ago

I would like it to, but I think that might require expanding the required modules, which would be slow without some caching mechanism (also not ideal). I'll look into it, though!

greghendershott commented 4 years ago

A couple semi-random things:

Someday/maybe you could tag some checks to run only in a "slower but more thorough mode". People might not want to use that slow/thorough mode in e.g. flycheck, but might want to use it as part of a make test run locally and/or on CI.
In the "prior work" part of the README it might make sense to list Jack's syntax-warn?

jackfirth commented 4 years ago

I'd also be happy to link to this project from syntax-warn.

Bogdanp commented 4 years ago

Someday/maybe you could tag some checks to run only in a "slower but more thorough mode". People might not want to use that slow/thorough mode in e.g. flycheck, but might want to use it as part of a make test run locally and/or on CI.

I like that idea, thanks!

In the "prior work" part of the README it might make sense to list Jack's syntax-warn?

Added! I think I saw @jackfirth mention it in one of his RacketCon talks, but then I completely forgot about it so thank you for the reminder.

jackfirth commented 4 years ago

Added a link to this from syntax-warn!