search

Bogdanp / setup-racket

A GH action for installing Racket.
MIT License
50 stars 9 forks source link

Allow disabling sudo on Linux #22

Closed shhyou closed 3 years ago

shhyou commented 3 years ago

This PR adds the option sudo: always and sudo: never for always running with/without sudo.

More context: When using a non-unix style installation, it is not necessary to run the installer with sudo. This can simplify later steps in the CI that touch packages in the main distribution. For example, the sudo commands can be removed here: https://github.com/shhyou/typed-racket/commit/382c068e847c75ebccf57ad22b3b0d35ee37b8ca

Bogdanp commented 3 years ago

Looks good, thanks! Would you mind adding a CI job to test the always and never variants on Linux?

shhyou commented 3 years ago

I added a CI job for running sudo: always and sudo: never. However, I am not sure how to test the always case because setup-racket installs in sudo mode by default.

Bogdanp commented 3 years ago

I think the one you've added is fine. It's good to have it as a sanity check. I made a couple of my own changes on top and released this as v0.14. Thanks again!