Bogidon / BVViewList

Dynamically add and remove views on a custom subclass of UIScrollView.
MIT License
6 stars 1 forks source link

Horizontal layout constraint errors. #10

Closed Bogidon closed 10 years ago

Bogidon commented 10 years ago

Inserting view in the horizontal layout throws a constraint error for the height of the view. screen shot 2014-06-20 at 18 11 56

jai commented 10 years ago

@Bogidon when in horizontal layout, should the user be allowed to add a view that isn't the full-screen height? Or do we force all views to be full screen? The previous iteration (vertical layout) had all views the same width as the screen so just checking.

Bogidon commented 10 years ago

The user should be able to add a view of any dimension. In the vertical layout, the user can add a view of any width.

On Jun 21, 2014, at 12:11 AM, Jai Govindani notifications@github.com wrote:

@Bogidon when in horizontal layout, should the user be allowed to add a view that isn't the full-screen height? Or do we force all views to be full screen? The previous iteration (vertical layout) had all views the same width as the screen so just checking.

— Reply to this email directly or view it on GitHub.

jai commented 10 years ago

And the view would just start from the top, not vertically center aligned, right? (In horizontal layout). Or should it be vertically centered?

Bogidon commented 10 years ago

Yay! It's fixed