search

BoiBetter / qira

Automatically exported from code.google.com/p/qira
0 stars 0 forks source link

qira browser history pwning #8

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Is there any way you can make qira not do this: http://i.imgur.com/Qv9Mylv.jpg ?

Original issue reported on code.google.com by Godo...@gmail.com on 4 Aug 2014 at 12:40

GoogleCodeExporter commented 8 years ago 
I think if you use the history API it won't, or implement something else to 
track the sessions. Changes like this are not high on my priority list, though 
if you implement them yourself and they are clean, I will merge into the 
codebase.

Original comment by geo...@gmail.com on 4 Aug 2014 at 9:44

GoogleCodeExporter commented 8 years ago

Original comment by geo...@gmail.com on 4 Aug 2014 at 10:11

GoogleCodeExporter commented 8 years ago 
Are you intending that people can have the ability to change values directly in 
the addressbar?

If not, all you need to change is this:

vmuser@vmuser-VirtualBox:~/project/godoppl-qirafork/web/client$ diff qira.js 
../../../qira/web/client/qira.js
20c20
<   window.location.replace ();
---
>   window.location.hash = hash;

Original comment by Godo...@gmail.com on 5 Aug 2014 at 1:21

GoogleCodeExporter commented 8 years ago 
Upon close inspection I noticed that it is actually possible to remove the 
window.location.hash = hash; completely. 
The window.location.replace (); results in an error in the log and does 
absolutely nothing..

Original comment by Godo...@gmail.com on 6 Aug 2014 at 12:00

GoogleCodeExporter commented 8 years ago 
So this is required to make back and forward work, the correct solution is the 
HTML5 history api.

Original comment by geo...@gmail.com on 14 Aug 2014 at 1:25

GoogleCodeExporter commented 8 years ago 
History is smart now! Thanks for the bug report.

Original comment by geo...@google.com on 21 Aug 2014 at 12:12