search

BoilerplateMVC / Backbone-Require-Boilerplate

A Rad Backbone.js and Require.js Boilerplate Project.
MIT License
604 stars 129 forks source link

Add remove logging to grunt #36

Closed andyscott12 closed 11 years ago

andyscott12 commented 11 years ago

Guys,

Is it possible to include this in the grunt ?

https://github.com/ehynds/grunt-remove-logging

Super easy to add and really convenient

gfranko commented 11 years ago

@andyscott12 This looks like a useful plugin, but I don't think this should be added to the core of the project. If anyone wants to use it, it is easy to add (like you said). What does everyone else think? @brettjonesdev @nickpack @skusunam

nickpack commented 11 years ago

@gfranko I am torn on this tbh, It is very useful indeed (I am as guilty as anyone else for leaving console.log's everywhere) but at the same time I feel the boilerplate needs to be lean. So am a little on the fence tbh - I think this may be another case for the scaffolding rather than direct inclusion.

gfranko commented 11 years ago

@nickpack I agree that this could potentially be in our yeoman generator. For now I'm going to close this as won't fix, but feel free to reopen if you feel strongly about adding this.