fix amdclean npm package version for hassle free minification

BoilerplateMVC / Backbone-Require-Boilerplate

A Rad Backbone.js and Require.js Boilerplate Project.

MIT License

604 stars 129 forks source link

fix amdclean npm package version for hassle free minification #46

Closed HongPong closed 10 years ago

HongPong commented 10 years ago

Hi, I had some trouble with minification on my app. After I looked at things, I realized that I had an older amdclean. After changing this package.json setting to the 2.x series, my minification worked just right. It's a cool framework, I like it a lot & it's a pretty good teaching tool as well.

You might want to look at bumping some of those other package versions as well, I'm not too familiar with them.

HongPong commented 10 years ago

To be more specific, after minifying in Chrome I got " Uncaught TypeError: Cannot set property '_handlers' of undefined " which was similar to some other bug threads on amdclean that were patched on the 2.x series.

gfranko commented 10 years ago

Yea, we need to show this repo a little bit more love and update a few different dependencies. Thanks for the PR and I'm glad that you are enjoying the framework!