Boilertalk / Web3.swift

A pure swift Ethereum Web3 library
MIT License
636 stars 187 forks source link

Fix ABI Decoding #135

Closed koraykoska closed 1 year ago

koraykoska commented 1 year ago

ABI tuple decoding was broken for multidimensional arrays (and not implemented for multidimensional tuple arrays). I fixed it and included a few test cases for the edge cases.

codecov-commenter commented 1 year ago

Codecov Report

Merging #135 (a971c64) into master (f76a23b) will increase coverage by 4.03%. The diff coverage is 94.91%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   70.86%   74.89%   +4.03%     
==========================================
  Files          63       64       +1     
  Lines        4438     4490      +52     
==========================================
+ Hits         3145     3363     +218     
+ Misses       1293     1127     -166     
Impacted Files Coverage Δ
Sources/ContractABI/ABI/ABIEncoder.swift 92.00% <ø> (+2.00%) :arrow_up:
...ntractABI/Contract/ContractPromiseExtensions.swift 100.00% <ø> (ø)
Sources/Core/Json/EthereumBlockObject.swift 95.23% <ø> (ø)
Sources/Core/Json/EthereumCall.swift 100.00% <ø> (ø)
Sources/Core/Json/EthereumData.swift 100.00% <ø> (ø)
Sources/Core/Json/EthereumLogObject.swift 0.00% <ø> (ø)
Sources/Core/Json/EthereumQuantity.swift 85.00% <ø> (ø)
Sources/Core/Json/EthereumQuantityTag.swift 100.00% <ø> (ø)
Sources/Core/Json/EthereumSyncStatusObject.swift 88.23% <ø> (ø)
Sources/Core/Json/EthereumTransactionObject.swift 50.00% <ø> (ø)
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.