Boilertalk / Web3.swift

A pure swift Ethereum Web3 library
MIT License
639 stars 188 forks source link

Swift5 #78

Closed koraykoska closed 5 years ago

koraykoska commented 5 years ago

General Swift5 compatibility / error and warnings fix.

koraykoska commented 5 years ago

The only real "breaking" change is the removed bytes label from the BytesInitializable interface. This is in order to match Swift stdlib APIs and be compatible with Data and other core classes.

codecov[bot] commented 5 years ago

Codecov Report

Merging #78 into master will decrease coverage by 0.66%. The diff coverage is 54.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   75.14%   74.48%   -0.67%     
==========================================
  Files          64       63       -1     
  Lines        4152     4205      +53     
==========================================
+ Hits         3120     3132      +12     
- Misses       1032     1073      +41
Impacted Files Coverage Δ
...s/Core/Json/EthereumTransactionReceiptObject.swift 0% <0%> (ø) :arrow_up:
...3/Classes/ContractABI/Contract/SolidityEvent.swift 64.44% <0%> (ø) :arrow_up:
Web3/Classes/ContractABI/ABI/Eth+ABI.swift 0% <0%> (ø) :arrow_up:
Web3/Classes/Core/Json/EthereumLogObject.swift 0% <0%> (ø) :arrow_up:
Web3/Classes/Core/Toolbox/BytesConvertible.swift 0% <0%> (ø) :arrow_up:
...Classes/Core/Toolbox/String+BytesConvertible.swift 78.57% <0%> (ø) :arrow_up:
.../Classes/Core/Json/EthereumTransactionObject.swift 50% <0%> (-22.23%) :arrow_down:
Web3/Classes/ContractABI/Contract/ERC165.swift 0% <0%> (ø) :arrow_up:
Web3/Classes/ContractABI/Contract/ERC20.swift 0% <0%> (ø) :arrow_up:
...lasses/Core/Toolbox/BigUInt+BytesConvertible.swift 100% <100%> (ø) :arrow_up:
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1cbe0a...0ef4e64. Read the comment docs.