search

Boilertalk / Web3.swift

A pure swift Ethereum Web3 library
MIT License
639 stars 188 forks source link

Change Web3HttpProvider init to use URL #98

Closed brettfazio closed 1 year ago

brettfazio commented 3 years ago

Change the String in the init to URL and thus it removes the possible error during unwrapping (the URL now has to be unwrapped by the user beforehand).

Also changed a test as it was taking in a String.

brettfazio commented 3 years ago

@koraykoska seems like this same CI failure is on every PR.

brettfazio commented 3 years ago

The reason I set it to a random URL if it fails to unwrap is that if it fails to unwrap all calls to this object (should) fail anyway. Ideally, people should probably use the init with the URL not the String.