Data space scoping

[Aaron3154518]

Not sure if this is an issue or not:

Different scopes can have two distinct variables (data spaces) with the same name. However all data spaces in the Computation class are given the same scope. This creates two distinct data spaces which are treated as one due to having the same name. We need to produce two differently named data spaces. We can implement this using a static integer counter. Every time we hit a redeclared variable in a new scope, rename it and every use of it within that current scope to var__v{counter}.

Example:

int foo = 0;
if (condition) { int foo = 1; } // different scope is not recognized in Computation
print (foo); // Should be 0, not 1.

Would become:

int foo = 0;
if (condition) { int foo__v1 = 1; } // different scope is not recognized, but variable is renamed so it's all good
print(foo);

[riftEmber]

Per meeting with Dr. O today, declaring a variable inside a nested scope should be disallowed. Upon encountering it spf-ie should error and exit.

[riftEmber]

How does this work for nested computations, which will very often have a decl inside a scope

[riftEmber]

Per today's meeting, spf-ie will fail upon encountering a declaraction with a name that matches an existing data space. This applies whether the declaration shadows an existing one, or if they are in different non-nested scopes. Because of this solution, declarations inside scopes besides the top-level are ok. Due to renaming this issue will never come up for nested computations.

[riftEmber]

Implemented in b8e0810e6a4248144ef891d87cd1b823d3ba0aeb