Change !=0 conditions to > 0, as a temporary fix

BoiseState-AdaptLab / spf-ie

Sparse polyhedral framework optimizing compiler frontend

4 stars 2 forks source link

Change !=0 conditions to > 0, as a temporary fix #6

Closed riftEmber closed 4 years ago

riftEmber commented 4 years ago

This is required because IEGenLib cannot support != constraints. The reason for the change should be clear, and a message should be emitted to the user explaining the substitution in case it will break functionality.

riftEmber commented 4 years ago

I believe it would be preferable to simply fail on a != condition and let the user decide if they'd like to rewrite it. Even with the warning emitted, I think the initially proposed change would introduce too much possibility for difficult-to-detect problems.

riftEmber commented 4 years ago

Closed by 1facc9d11ffa7038ce7d4235c7a2d2df0f57d24a