BoldGrid / boldgrid-theme-framework

The BoldGrid Theme Framework used in BoldGrid themes.
https://www.boldgrid.com/theme-framework/
GNU General Public License v3.0
17 stars 7 forks source link

Featured images for posts on blog page should link to post. #732

Closed jamesros161 closed 2 years ago

jamesros161 commented 2 years ago

This addresses #399

Description

Featured images for posts on blog page should link to post. The solution decided for this feature is, rather than have a toggle for whether the featured images should be links or not, this behavior will be standard. This is understood / expected behavior which was not previously included. This feature will apply to featured images for posts on the Post List ( Blog ) Page, with a featured image position of Above Header, Below Header, and In Post Content. This will not apply to 'Header Background' position setting, as this would interfere with the post meta links that are overlaying on top of the background image.

This specific PR only addresses the styling of the element for the link. The actual changes to the template can be found in Prime/PR#142

Testing Procedure

NOTE: Testing procedures for this PR and Prime/PR#142 are the same.

  1. Install the test version of Crio attached to this PR. crio-2.17.0-pr.732.zip. Alternatively, you can use this one-click install link to install this test zip on Cloud Wordpress.
  2. Ensure that you have a 'Blog' page, with at least one blog post. If installing Crio on a clean install, this can easily be done by adding the starter content.
  3. Add a featured image to at least one blog post if it doesn't already have it.
  4. In the WordPress Customizer, navigate to Design → Blog → Blog Page → Post List Settings → Featured Images
  5. Test the Following positions: Above Header, Below Header, and In Post Content and ensure that each option links to the post.
joe9663 commented 2 years ago

Acceptance testing completed