search

BoldGrid / boldgrid-theme-framework

The BoldGrid Theme Framework used in BoldGrid themes.
https://www.boldgrid.com/theme-framework/
GNU General Public License v3.0
17 stars 7 forks source link

Issues 738 & 733 #740

Closed jamesros161 closed 2 years ago

jamesros161 commented 2 years ago

Resolves #738 Resolves #733

Testing Instructions

Install the attached Crio Zip File. crio-2.17.1-rc2.zip

Testing Issue #738

  1. Create a post with two buttons, with one button having the .button-primary class and the other having the .button-secondary class. ( Alternatively, install the Crio Starter content, and you can use the section of the home page that already has two buttons side by side to test.
  2. In the WordPress Customizer, customize both the primary buttons and the secondary buttons setting both to size 4 ( btn-large ).
  3. Ensure that both the Button Primary and the Button Secondary buttons are the same size, line up properly, and that the font behaves the same.
  4. Add the .btn and .button-primary class to a menu item, and ensure that the button behaves itself.
  5. Change the menu item classes to use .button-secondary and make sure that it still behaves itself.
  6. Create a button that does not utilize either the .button-primary or .button-secondary classes by using the PPB Button Component, and ensure that the buttons still behave as expected.

Testing Issue #733

  1. Setup the footer for your site to utilize the Customizer Footer, with at least one widget area.
  2. In that widget area, add a 'Custom HTML' widget, with the following markup: 
    <a class="btn button-primary">Button Primary</a>
<a class="btn button-secondary">Button Secondary</a>
  3. Ensure that the Buttons' styling in the footer matches that of the buttons in the site content ( background, border, text, and hover effects ).
nicolepaschen commented 2 years ago

button-text

The text does not seem centered in the button until I undo the height (see gif) I had a thick border on the button

nicolepaschen commented 2 years ago

alignment is off in the editor now: image

nicolepaschen commented 2 years ago

Buttons in the footer do not look correct either they look like how they look in the editor (live preview and font end look the same): image

nicolepaschen commented 2 years ago

custom footer menu buttons look super wonky until I save, then still not correct. front end is correct tho. also the menu buttons have a hover effect they should not have in the editor. footer-menu-buttons