search

BoldingBruggeman / getm-rewrite

Rewrite of the General Estuarine Transport Model (GETM) in Python (mostly) and Fortran (performance-critical sections)
https://pygetm.readthedocs.io/
Other
7 stars 3 forks source link

New test case: Kelvin wave in a 2D periodic channel #11

Closed markusReinert closed 3 years ago

markusReinert commented 3 years ago

We propose to add to the python branch the test case of a Kelvin wave in a periodic channel on a 2D domain. It simulates the propagation of a wave along the coast and agrees with the predictions of linear wave theory.

Here are two screenshots showing the initial condition and the situation after the wave has travelled twice through the domain:

Screenshot of the initial Kelvin wave Screenshot of the Kelvin wave after 28h

bolding commented 3 years ago

Hi Markus

Does the configuration do as you expected - and has the previous issues been sorted out?

In the long run I think we will put the notebooks in a dedicated repository as we can then use 'binder' to run them (i.e. people who want to try out do not need to install anything). This notebook repository can be a submodule the the main repository - so you'll get it when you clone.

Karsten

markusReinert commented 3 years ago

Hi Karsten,

yes, it does now exactly as we expect. I've just emailed you the details of how we sorted out the previous issues.

Using Binder sounds like a nice idea.

Markus