search

BoldingBruggeman / getm-rewrite

Rewrite of the General Estuarine Transport Model (GETM) in Python (mostly) and Fortran (performance-critical sections)
https://pygetm.readthedocs.io/
Other
7 stars 3 forks source link

Momentum #9

Closed bolding closed 3 years ago

bolding commented 3 years ago

various updates to the momentum module

compiles on gfortran and ifort

Knut - can the call to advection_2d() be moved into uv_momentum_2d()? If so it does not need to be a public member of the momentum modules.

knutaros commented 3 years ago

On 11/2/20 8:09 AM, Karsten Bolding wrote:

various updates to the momentum module

compiles on gfortran and ifort

Knut - can the call to advection_2d() be moved into uv_momentum_2d()? If so it does not need to be a public member of the momentum modules.

depends. in principle you could use uv_advection_2d() also for the slow terms. but then you have to provide a corresponding type_getm_momentum that contains the mean barotropic currents

    You can view, comment on, or merge this pull request online at:

https://github.com/BoldingBruggeman/getm-rewrite/pull/9 https://github.com/BoldingBruggeman/getm-rewrite/pull/9

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BoldingBruggeman/getm-rewrite/pull/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2RV6UX735ENPKB5NUI5TLSNZLJVANCNFSM4THDCDOQ.

knutaros commented 3 years ago

why do you change at several places from MODULE PROCEDURE to MODULE SUBROUTINE ?

On 11/2/20 8:11 AM, Karsten Bolding wrote:

@bolding https://github.com/bolding requested your review on: #9 https://github.com/BoldingBruggeman/getm-rewrite/pull/9 Momentum.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/BoldingBruggeman/getm-rewrite/pull/9#event-3946552658, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2RV6RJPPPUEV2EO4UN6BLSNZLQ3ANCNFSM4THDCDOQ.

bolding commented 3 years ago

ifort gave Compiler panic with MODULE PROCEDUREs when Jorn compiled on Windows - and I could reproduce on Linux

It is an error in ifort - and annoying since I would prefer the MODULE PROCEDURE to avoid duplicating the interface information

bolding commented 3 years ago

it is easy to adjust the code such that uv_advection_2d() can be used for other velocity fields as well