Closed bolding closed 3 years ago
On 11/2/20 8:09 AM, Karsten Bolding wrote:
various updates to the momentum module
compiles on gfortran and ifort
Knut - can the call to advection_2d() be moved into uv_momentum_2d()? If so it does not need to be a public member of the momentum modules.
depends. in principle you could use uv_advection_2d() also for the slow terms. but then you have to provide a corresponding type_getm_momentum that contains the mean barotropic currents
You can view, comment on, or merge this pull request online at:
https://github.com/BoldingBruggeman/getm-rewrite/pull/9 https://github.com/BoldingBruggeman/getm-rewrite/pull/9
Commit Summary
Merge pull request #1 from BoldingBruggeman/devel
momtum_2d: split coriolis terms in separate subroutines
momentum:
File Changes
M src/dynamics/momentum.F90 https://github.com/BoldingBruggeman/getm-rewrite/pull/9/files#diff-46440a9ab180c65cc7cd4a49b1f7c862c14f214460112a9d01455afd517eba0d (158)
M src/dynamics/momentum_2d.F90 https://github.com/BoldingBruggeman/getm-rewrite/pull/9/files#diff-83cfe6d225edf9df7fb39ca64b66ff5b83b200ba6d439e7ce27b86a6cd8cd528 (203)
M src/dynamics/momentum_3d.F90 https://github.com/BoldingBruggeman/getm-rewrite/pull/9/files#diff-75ea562b2d42330c6fe942d5ff894cabd9ca2f0a70e6dad9c6a2b59f07f65e2f (87)
M src/dynamics/momentum_register.F90 https://github.com/BoldingBruggeman/getm-rewrite/pull/9/files#diff-4b94e58dc01d056826f34da0943e2c1b6fa19f03d1b5b5491683dfd7121f3487 (3)
M src/dynamics/shear.F90 https://github.com/BoldingBruggeman/getm-rewrite/pull/9/files#diff-11dc16852f193dd7abb9bb388c5279f92b3d28ae39ff8efcc94b36ff474963bd (4)
M src/dynamics/slow_terms.F90 https://github.com/BoldingBruggeman/getm-rewrite/pull/9/files#diff-ac940505ff6dee4bfad4840cca2adf1ad13c34322933f05e9ac631c260b6ea3f (17)
M src/dynamics/velocities.F90 https://github.com/BoldingBruggeman/getm-rewrite/pull/9/files#diff-c95d8d7b2ccbd78ff67c26fc286c50b3f88193ebc0c3a9546980384f246947fe (44)
M src/getm.F90 https://github.com/BoldingBruggeman/getm-rewrite/pull/9/files#diff-cd90226d545166394b34b6b6dd33800c3a2bc4d4342dbf07a80b6ecf0e7061c0 (4)
Patch Links:
https://github.com/BoldingBruggeman/getm-rewrite/pull/9.patch https://github.com/BoldingBruggeman/getm-rewrite/pull/9.patch
https://github.com/BoldingBruggeman/getm-rewrite/pull/9.diff https://github.com/BoldingBruggeman/getm-rewrite/pull/9.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BoldingBruggeman/getm-rewrite/pull/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2RV6UX735ENPKB5NUI5TLSNZLJVANCNFSM4THDCDOQ.
why do you change at several places from MODULE PROCEDURE to MODULE SUBROUTINE ?
On 11/2/20 8:11 AM, Karsten Bolding wrote:
@bolding https://github.com/bolding requested your review on: #9 https://github.com/BoldingBruggeman/getm-rewrite/pull/9 Momentum.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/BoldingBruggeman/getm-rewrite/pull/9#event-3946552658, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2RV6RJPPPUEV2EO4UN6BLSNZLQ3ANCNFSM4THDCDOQ.
ifort gave Compiler panic with MODULE PROCEDUREs when Jorn compiled on Windows - and I could reproduce on Linux
It is an error in ifort - and annoying since I would prefer the MODULE PROCEDURE to avoid duplicating the interface information
it is easy to adjust the code such that uv_advection_2d() can be used for other velocity fields as well
various updates to the momentum module
compiles on gfortran and ifort
Knut - can the call to advection_2d() be moved into uv_momentum_2d()? If so it does not need to be a public member of the momentum modules.