Bolls-Bible / bain

A web app for reading the Bible with full emphasis on the God`s Word only. Sola scriptura
https://bolls.life
67 stars 10 forks source link

Request. Bookmark marks in navigation. #8

Closed garrett85 closed 1 year ago

garrett85 commented 1 year ago

I don't see anywhere to normal discussion, feedback, or request so my apologies if this is the wrong place to put this. But there's two small features I would like to see.

I like the fact the we have bookmarks and notes but unless your directly over the text where you a bookmark you wouldn't know it was there. I would like to see some kind of a flag on the left hand chapter navigation showing that you have a bookmark or note in that particular book/chapter.

I would also like to maybe see two special bookmarks, one primary bookmark for each testament, one for the old and one for the new.

My thoughts after using Bolls. Thanks.

Bohooslav commented 1 year ago

Idk, I'll try to investigate it. I may put some color dots under chapter numbers indicating that there are notes/bookmarks.

I hope there is no much sense to put also highlights there, since there may be too much of them

Bohooslav commented 1 year ago

Sorry for late reply, didn't get any notifications from Github. Now have a short vacation, will do what I can.

Bohooslav commented 1 year ago

You meant something like this in navigation? image

Bohooslav commented 1 year ago

https://github.com/Bolls-Bible/bain/pull/10

Bohooslav commented 1 year ago

@garrett85 this feature is already released for a while and seems to be stable. Please give feedback and close this issue if I fulfilled your desire. Thanks

rik-shaw commented 1 year ago

I like the approach you used, and I understand that if you had dots under each chapter for hilights it would be too busy / not very informative since it may just be that every single chapter would have marks under it.

This said, having a separate view for highlights+notes may really be nice. Sometimes when I am rushed it is nice to read through the verses I have hilighted for a book when I don't have time to read more. Sorting it by when the highlight was made is also nice, you can then re-live what you were doing and where you were when the scripture made an impact on you. So the hilight list could be sorted by chronological or scripture order.

This may take some consideration if it is in line with the approach of Bolls, and if it is clear enough to implement well without being cluttered. But I personally think that users may appreciate it.

Bohooslav commented 1 year ago

I am not sure if I understand everything, but here is what I can do now. You can view your bookmarks in your profile, which is located right there (your name should be there)

image

Currently, they are sorted from latest to oldest, but I guess it makes sense to add filters, to be able to filter and order bookmarks by book / translation. I hope that should enough.