BolognaBiocomp / deepsig

DeepSig - Predictor of signal peptides in proteins based on deep learning
https://deepsig.biocomp.unibo.it
GNU General Public License v3.0
22 stars 4 forks source link

Relax python restrictions to allow Python >= 3.8 -> 3.9 #30

Open oschwengers opened 2 years ago

oschwengers commented 2 years ago

Hi Savojardo, currently, DeepSig pinpoints dependencies for Python, keras and tensorflow to 3.8, 2.4.3 and 2.2.0, respectively. However, this will forestall many useful updates and might hinder the creation of larger environments using DeepSig with other tools.

To integrate DeepSig into Bakta, I once again took a look and successfully managed to increase Python, keras and tensorflow dependencies to 3.9, 2.6.0 and 2.6.2, respectively. This also worked with Python 3.8:

To streamline these verison bumps I also added two unit tests that are automatically triggered on each commit and executed by the GitHub CI system:

I think this might be a worthy step forwards in terms of long term software stability and usability. Could you please take a look at this, test it yourself and consider this PR?

oschwengers commented 2 years ago

You can take a look at the the last and successful unit tests at:

Unfortunately, I had to disable these tests from MacOS as the CI was not able to execute biocrf-static. I guess this is not related to the CI and maybe a distinct issue with DeepSig and MacOS.