BoltAuth / Auth

Auth extension for Bolt
MIT License
16 stars 17 forks source link

[BUG] Pagination not working #34

Closed melcarthus closed 4 years ago

melcarthus commented 6 years ago

The 11th entry does not show. Page does not load pagination and only the first 10 accounts are visible.

Details

Happens on /bolt/extensions/auth Add 11 accounts, you will see that there are only 10 visible. Change 10 to 20 for example here: https://github.com/BoltAuth/Auth/blob/f1080cec5e805b907be9c84d2943d5d2de1ed7a8/src/Controller/Backend.php#L177-L179 and you will see the accounts are still there, just no pagination.

If you're filing a bug, please describe how to reproduce it. Include as much relevant information as possible, such as: ​ other plugins that are installed Seo 1.10 BoltForms 4.2.3 EmailSpooler 3.1.1 Sitemap 2.5.0 google/recaptcha 1.1.3 pagerfanta/pagerfanta 1.1.0 Paragonie/random_compat 2.0.15 ramsey/uuid 3.7.3

SvanteRichter commented 6 years ago

It seems like the pager isn't setting the page query param correctly. I try to see if I get time to fix or if anyone else has a PR I'd be glad to merge.

ncareau commented 5 years ago

@SahAssar Fix is done, can you merge ? Thank you.

zeamedia commented 4 years ago

Hey all. Is there any update on this issue?

melcarthus commented 4 years ago

Yes a year ago there was a fix. Was it never merged into production?

zeamedia commented 4 years ago

Yes, I've just seen the fix in the linked issue - works for me as well. I am wondering why this fix never has been merged into production.

{% include '@bolt/components/pager.twig' with { 'pager': pager.pager, 'surround' : pager.surr } only %}