BoltDoggy / parcel-plugin-vue

⚠️ parcel-bundler/parcel @1.7.0 support Vue Now. This plugin will be not recommended.
https://github.com/parcel-bundler/parcel
209 stars 15 forks source link

ws has hardcoded localhost #14

Open pabloveliz opened 6 years ago

pabloveliz commented 6 years ago

description

When using a different hostname (like IP) the HMR still points to localhost.

reproduction

parcel 1.4.1 using 0.0.0.0 as host and accessing from another machine by IP gives this error on the console browser

fix?

I manually edited src/builtins/hmr-runtime.js changing line 19 with ' + global.location.hostname + ' as suggested on this pull from parcel https://github.com/parcel-bundler/parcel/pull/476/files