search

BoltTranslate / Translate

Provides translation for contenttypes.
Other
43 stars 37 forks source link

Translated Templatefields #127

Closed nealmarques closed 7 years ago

nealmarques commented 7 years ago

Fixes issue for when a templatefields are defined as translatable but no template is actually selected and the default record template has customfields.

I also added a fix for Bug: #110

SvanteRichter commented 7 years ago

Hey, Sorry it's taken me so long to look over this! Do you mind if I be a bit nitpicky on this? Otherwise I'll just fix it up in a separate branch, but I'll leave a few comments and you lemme know.

nealmarques commented 7 years ago

No worries, please feel free to fix it up. I just wanted to document what I did to fix the issues I kept seeing. I just finished up a big translation job with all kinds of variations of content types with specified templates, and non specified templates and default templates; so I hope I ran into every kind of template combination translation scenario. Take a look, I hope what I wrote makes sense.

Regards,

Neal

On Mon, Aug 21, 2017 at 8:36 PM, notifications@github.com wrote:

Hey, Sorry it's taken me so long to look over this! Do you mind if I be a bit nitpicky on this? Otherwise I'll just fix it up in a separate branch, but I'll leave a few comments and lemme know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AnimalDesign/bolt-translate/pull/127#issuecomment-323832422, or mute the thread https://github.com/notifications/unsubscribe-auth/AFGF5ctm9lFGvRxhEdxXZDT1TlRwX0lDks5sadwmgaJpZM4Ow9Sk .

SvanteRichter commented 7 years ago

Merged via #132