BoltTranslate / Translate

Provides translation for contenttypes.
Other
43 stars 38 forks source link

[BUG] Changelog is impossible to follow #183

Open gagarine opened 5 years ago

gagarine commented 5 years ago

The active language will be saved in the DB field. So each time you save you content in a different language all the field are going to be overwrites. I do have the feeling this can be problematic. The first problem I can see is with the change-log: screenshot 2018-10-17 at 02 40 13

Proper solution need a database structure change and certainly content translation support in bolt core. Having one table for each language for example. Or best one for each translated field.

As a workaround, always save in the same language in the table field?

SvanteRichter commented 5 years ago

As a workaround, always save in the same language in the table field?

Sorry, not sure what that means, could you explain? Regarding the separate tables, I have since answered that in that issue.

gagarine commented 5 years ago

I mean do not save in the current language in the "non serialized field" but always in the "default language". So the diff are a bit more clean and the log easier to follow.

SvanteRichter commented 5 years ago

Hmm, I haven't used translate in a while, but the idea was to only save the default language in the normal bolt columns, and save overrides only in the json column for that locale. So if it's resaving non-default translations in the normal fields then that is a bug.

gagarine commented 5 years ago

It's what happened in my test. Perhaps, I didn't configure the default language correctly. I will test it again.

On Sat, Nov 3, 2018 at 10:28 AM SahAssar notifications@github.com wrote:

Hmm, I haven't used translate in a while, but the idea was to only save the default language in the normal bolt columns, and save overrides only in the json column for that locale. So if it's resaving non-default translations in the normal fields then that is a bug.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BoltTranslate/Translate/issues/183#issuecomment-435573750, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKA6gRsbj3woQKYkDLeejYt7NJdUui6ks5urWG8gaJpZM4Xi3cu .