Fix for field type blocks

BoltTranslate / Translate

Provides translation for contenttypes.

Other

43 stars 38 forks source link

Fix for field type blocks #186

Closed tiito78 closed 5 years ago

tiito78 commented 5 years ago

Fix for field type blocks. Prevent from getting "__internal" error on blocks.

doenietzomoeilijk commented 5 years ago

I can confirm this (together with bolt/bolt#7705) fixed the problem with translations for Block field types in a Bolt 3.6 + Translate 4.1.4 setup.

SvanteRichter commented 5 years ago

I'll let/force @bobdenotter have the call on this since he has had more involvement here lately than me. Personally it feels like it's repeating the hack I had to do to make repeaters work which means that it is ugly, but probably works unless you poke it too much.

As a hold-over until we get bolt v4 I'd be OK-ish with it.

tiito78 commented 5 years ago

that's what is its.. the same hack for repeaters. Feel free to use it, or just leave it. As @doenietzomoeilijk wrote the hack is doing the work, and me my self can also confirm that.

bobdenotter commented 5 years ago

Thanks, @tiito78! 👍

Let's ship, and do it better in v4. :shipit: