search

BoltTranslate / Translate

Provides translation for contenttypes.
Other
43 stars 38 forks source link

og:locale in Bolt SEO Premium Extension™ v0.10.3 Platinum Edition Pro #84

Closed evertalbers closed 7 years ago

evertalbers commented 7 years ago

I see that the default install of aforementioned plugin does not 'pick up' the locale, on a Dutch example it still says <meta property="og:locale" content="en_GB" />

SvanteRichter commented 7 years ago

This is because the SEO extension gets the locale from the config file instead of the set locale, could you try replacing https://github.com/bobdenotter/seo/blob/master/templates/_metatags.twig#L7 with <meta property="og:locale" content="{{ htmllang()|replace({'-': '_'}) }}" />?

evertalbers commented 7 years ago

Yep, it worked! Maybe you will want to add this to the translate docs somewhere?

Related, I also made a pull request for Bolt SEO Premium Extension™ https://github.com/bobdenotter/seo/pull/31

SvanteRichter commented 7 years ago

Hmm, I was hoping to get a more permanent (automatic) and proper (without twig replaces) fix in to the seo extension, @bobdenotter would you be okay with that?

bobdenotter commented 7 years ago

@SahAssar Yes, sounds good. If you have a plan, I'm all for that. :-)

evertalbers commented 7 years ago

In that case you could also look at pre-filling title/meta fields from Translate-pages to SEO.

SvanteRichter commented 7 years ago

PR opened in the seo repo.

madc commented 7 years ago

The two PRs have been merged. Does that mean, we can close this issue? @SahAssar was mentioning, its only a temporary fix..

SvanteRichter commented 7 years ago

It's good enough for me :)