search

BoltTranslate / labels

Bolt Labels extension - Translatable labels for Bolt
https://bolt.cm/
18 stars 12 forks source link

Added the htmlsnippets #10

Closed phpetra closed 8 years ago

phpetra commented 8 years ago

And re-added setting the currentLanguage() to the initialization so it's available in the twig templates and the translations work again.

phpetra commented 8 years ago

@GawainLynch For now I just refactored that bit back to what it was, before it was broken, see previous version (cause I would like to actually use the extension).

I'm guessing default language of the config file should be the fallback?

Do you have an example of how to do that with the before middleware?

phpetra commented 8 years ago

@GawainLynch I just tested and fixed the default fallback. It's in a separate PR: (https://github.com/bolt/labels/pull/11)

SvanteRichter commented 8 years ago

@phpetra The SEO extension uses a before handler here: https://github.com/bobdenotter/seo/blob/master/Extension.php#L66-L81 and it's registered on L30

phpetra commented 8 years ago

@SahAssar Thanks! That looks understandable enough, I'll try to implement first thing tomorrow ;-)

phpetra commented 8 years ago

@GawainLynch Can you have another look and see if all is satisfactory now? I merged all changes into this single PR.

bobdenotter commented 8 years ago

Looking good to me!

bobdenotter commented 8 years ago

@phpetra What was "the file path issue" you mentioned on Slack, yesterday? :-)