Closed lenvanessen closed 6 years ago
Hey @lenvanessen,
Thanks for the PR. Looks good to me, except:
if it we're not viewing in the default language.
As we've (briefly) chatted about on slack, I don't think we should do that.
I do understand how you assumed that it would be, so perhaps instead of the && $lang != $defaultLang
, we should make the README a bit more clear about intent? :-)
Hi Bob,
Yeah, my approach was a bit off! Understandable:) I think hinting a bit more in the docs would be fine!:)
In my installation all the labels got wrapped in a
<mark>
, even though I was viewing them in the default locale (which means the translations are in fact the strings in the code).What I've done:
It worked in my case, but might be wise for someone that knows the plug-in better to check if i'm on the right track with this pr