search

BoltsFramework / Bolts-ObjC

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
5.65k stars 578 forks source link

Fix Xcode analyze warning #304

Closed baoshan closed 7 years ago

baoshan commented 7 years ago

Below analyze hints can be found:

BFTask.m:89:12: nil passed to a callee that requires a non-null 1st parameter.

...
return [[self alloc] initWithResult:result];

This PR fix the analyze warning. Please check if the diff makes any sense.

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

nlutsenko commented 7 years ago

Hey @baoshan, thank you for fixing it and welcome to the list of contributors. This is good to go and should have been that way in the first place, since the public API declares the result in the class contructor as billable anyway.