search

BoltsFramework / Bolts-ObjC

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
5.65k stars 578 forks source link

Targets built with coverage data in Xcode 9 gives error #306

Closed txaiwieser closed 3 years ago

txaiwieser commented 6 years ago

Solves #305 :)

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

MikeSilvis commented 6 years ago

Can we please get this merged?

z4r commented 6 years ago

Any update?

MikeSilvis commented 6 years ago

@baoshan @nlutsenko @valeriyvan We are now going on an entire quarter of not being able to build the facebook SDK using Carthage. This is starting to become absolutely ridiculous. Can we please get this thing merged so I can stop using an internal fork.

txaiwieser commented 6 years ago

Please, its a simple PR!

nlutsenko commented 6 years ago

Hey guys, sorry for delayed response. I just tested master version of Bolts with Xcode 9.2 and when built via Carthage - it looks like everything is smooth and no llvm diagnostics data is getting emitted.

I understand that having code coverage disabled is blocking submission via iTunes Connect, however we depend on code coverage being turned on for instrumentation purposes (and to actually see the code coverage), so I would appreciate if you give it another go and report here if you still can't submit the app with the current master of Bolts.

If that is the case - I'll happily go ahead and change the way we do schemes so we only use code coverage on schemes meant for testing or find another way to keep these settings on for dev purposes only.