search

BoltsFramework / Bolts-ObjC

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
5.65k stars 578 forks source link

Fix Implicit retain of self within blocks warnings #318

Closed legranddamien closed 6 years ago

legranddamien commented 6 years ago

Xcode 9.2 introduced a new warning : Implicit retain of 'self' within blocks. Since then I have theses warning in my personal project. This pull request fix this.

warnings_screenshot
nlutsenko commented 6 years ago

Thank you, and welcome to the project! The change of xcodeproj files is a no-go, since we manage the configurations via shared xcconfig files.

I just pushed an update to xctoolchain, which enables this warning. Please blackout the change on xcodeproj and update the submodule here as part of your pull request.

legranddamien commented 6 years ago

Hi @nlutsenko, I removed the changes in xcodeproj, and git pull in Vendor/xctoolchain. I'm not familiar with submodules, I don't know if there is more to do to update the submodule.

kikettas commented 6 years ago

Are you planning to release a minor version for this? @nlutsenko