search

BoltsFramework / Bolts-ObjC

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
5.65k stars 578 forks source link

fix facebook build on xcode 10 using carthage #323

Closed Nonnus closed 4 months ago

Nonnus commented 6 years ago

This pr fixes compiling facebook-ios-sdk and facebook-swift-sdk with latest xcode 10 using carthage by implementing the fixes described in https://github.com/facebook/facebook-sdk-swift/issues/246

ps: to be clear, when building Bolts directly using Carthage there was no issues at all, including compiling on latest beta 6, it is just when compiling either facebook-ios-sdk or facebook-swift-sdk that the problem arises

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

uson1x commented 5 years ago

Any chance we could get this merged, if it fixes the issue? Facebook SDK is not compiling via carthage using latest Xcode 10 GM command line tools

codytwinton commented 5 years ago

This appears to have been resolved by PR #324

milanitaliya commented 4 years ago

@nlutsenko I am searching updated bolt.framework file, I don't want to use pods. I want just "bolt.framework" so I can just. replace in my existing project . I can't find framework.