search

BoltsFramework / Bolts-ObjC

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
5.65k stars 578 forks source link

Move to WKWebView (required by Catalyst) #332

Closed mman closed 4 years ago

mman commented 4 years ago

This pull request replaces use of now deprecated UIWebView with WKWebView allowing Bolts-ObjC to be used in in Catalyst apps.

The changes are rather straightforward, but I do not use this code at all so I just made it compile under Catalyst and not tested it at all.

facebook-github-bot commented 4 years ago

Hi mman! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

nlutsenko commented 4 years ago

Should be all set as of Bolts 1.9.1, as all references to UIWebView are gone now. Let me know if there is anything left.