search

BoltsFramework / Bolts-ObjC

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
5.65k stars 578 forks source link

UIWebview -> WKWebView ( Tested ) #334

Closed roremeol closed 4 years ago

roremeol commented 4 years ago

This pull request replaces use of deprecated UIWebView with WKWebView allowing Bolts-ObjC to be used without Apple's warning emails about deprecation of UIWebView.

This code have passed for all tests.

facebook-github-bot commented 4 years ago

Hi @roremeol!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

pushparajsamant commented 4 years ago

@mskobe @roremeol Can someone please create a release so it can be pulled in using pods.

roremeol commented 4 years ago

@mskobe @roremeol Can someone please create a release so it can be pulled in using pods.

Sorry, i can't help you! As you, i'm only a programar who has problems to submit an app to Apple‘s Store and i don't have privilege enough to do it.

If it can help you i changed the Bolts‘s source inside my project on Pods folder.

Beast regards

pushparajsamant commented 4 years ago

Ohhh okay .... anyways thanks for your work mate. Really saved me.

pushparajsamant commented 4 years ago

@nlutsenko Can you please add this in a release. If I run pod install it is currently not getting the latest code.

mskobe commented 4 years ago

@nlutsenko Could you make a new release?

radvansky-tomas commented 4 years ago

Any update ?

nlutsenko commented 4 years ago

The new release is up for a while now.

dwhipps commented 3 years ago

This is still broken somewhere (perhaps Bolts? Apple doesn't say), but my app is still being rejected from the store because of UIWebView usage.

mskobe commented 3 years ago

@dwhipps Don't think so. I have been able to submit multiple apps without any issue of this

roremeol commented 3 years ago

@dwhipps Try to find “UIWebView” inside pods folder, maybe there is one or more dependicies who still does not update there source.

dwhipps commented 3 years ago

My mistake. This was another library altogether, which was also using UIWebView (an older version of OneSignal.framework if you're curious.) Sorry for the false alarm. Apple doesn't say where they found the problem, so it's been a lot of frustrating trial and error.