search

BoltsFramework / Bolts-Swift

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
1.32k stars 124 forks source link

Swift 4.0 Support #64

Closed nlutsenko closed 7 years ago

nlutsenko commented 7 years ago

Includes all the changes required to support Swift 4.0 Also cleans up tests, since it's finally possible with Swift 4.

Superseds and closes #62 Fixes #59 Fixes #61

nlutsenko commented 7 years ago

Hey @akwilliamson, sorry I took over your Pull Request #62. Would appreciate your eyes and review on this.

This is about the same amount of changes for the core library, but also includes changes to enable warnings introduced in Xcode 9 and fully fix all the warnings introduced in Swift 4. It also adds some cosmetic nice things on top 🍰

akwilliamson commented 7 years ago

Looks good to me.

flovilmart commented 7 years ago

👍 thanks !