search

BoltsFramework / Bolts-Swift

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
1.32k stars 124 forks source link

Targets built with coverage data in Xcode 9 gives error #65

Closed txaiwieser closed 5 years ago

txaiwieser commented 7 years ago

Solves #305 :) and is Linked to Bolts-Objc PR (https://github.com/BoltsFramework/Bolts-ObjC/pull/306)

Thanks :)

z4r commented 7 years ago

Any ETA to solve this issue? thx

txaiwieser commented 7 years ago

It’s already solved on my branch, it only needs to be merged! :)

facebook-github-bot commented 7 years ago

@txaiwieser I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

nlutsenko commented 5 years ago

Shouldn't be a problem anymore. Please ping this PR if it still is a problem and let's revisit it then.