search

BoltsFramework / Bolts-Swift

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.
Other
1.32k stars 124 forks source link

Remove flatMap because it is now deprecated in Swift 4.1 #71

Closed sebleclerc closed 6 years ago

sebleclerc commented 6 years ago

With the release of Xcode 9.3 / Swift 4.1, Sequence.flatMap is deprecated for the usage of removing nil elements in a list. It has been replaced with new Sequence.compactMap as per this doc link: https://github.com/apple/swift-evolution/blob/master/proposals/0187-introduce-filtermap.md

This commit removes the compiler warning.

facebook-github-bot commented 6 years ago

@sebleclerc I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.