BoltsFramework / Bolts-Swift

Bolts is a collection of low-level libraries designed to make developing mobile apps easier.

Other

1.32k stars 123 forks source link

[TravisCI] fix it, test with Swift 4.0 and 4.2 (5.0 prepared) #87

Closed HeEAaD closed 5 years ago

HeEAaD commented 5 years ago

Motivation

I see that a lot of PRs are not accepted because of red Travis CI builds. This leads to three open Swift 5.0 upgrade PRs.

Description

This PR makes all travis matrix builds green. Furthermore it makes it possible to test this project with a range of Swift versions.

Configured matrix:

SDK	SWIFT_VERSION	Xcode
ios	4.0	9.0
ios	4.2	10.0
ios	5.0	10.2 (commented out because the project is not buildable with Swift 5.0 yet)
macos	4.0	9.0
appletv	5.0	9.0

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

rostopira commented 5 years ago

Why it's not merged?

nlutsenko commented 5 years ago

Beautiful! Thank you!