BoltzExchange / boltz-client

Boltz Client for CLN & LND
MIT License
37 stars 13 forks source link

Set default wallet name #180

Closed kilrau closed 1 month ago

kilrau commented 2 months ago

Didn't choose a name during auto setup as it gave me the impression it'll set it to autoswap by default: ? Enter a name for the new wallet (autoswap)

But nope:

    {
      "id": "7",
      "name": "",
      "currency": "LBTC",
      "readonly": false,
      "balance": {
        "total": "0",
        "confirmed": "0",
        "unconfirmed": "0"
      },
      "entityId": "1"
    }

Let's default names to autoswap, autoswap (1), etc to avoid empty names. Running boltzcli wallet remove "" errors and I don't want to even know what happens when I create another wallet without name now.

$ boltzcli wallet remove ""
? Make sure to have a backup of the wallet. Do you want to continue? Yes
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa1ad74]

goroutine 1 [running]:
main.removeWallet(0xc0002c3480)
    /home/kilrau/GitHub/boltz-client/cmd/boltzcli/commands.go:1793 +0xd4
main.init.requireNArgs.func34(0xc0002c3480)
    /home/kilrau/GitHub/boltz-client/cmd/boltzcli/utils.go:81 +0x53
github.com/urfave/cli/v2.(*Command).Run(0x12d7a00, 0xc0002c3480, {0xc0001c1f60, 0x2, 0x2})
    /home/kilrau/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/command.go:274 +0x93f
github.com/urfave/cli/v2.(*Command).Run(0x12d71c0, 0xc0002c3340, {0xc000328720, 0x3, 0x3})
    /home/kilrau/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/command.go:267 +0xb7d
github.com/urfave/cli/v2.(*Command).Run(0xc0001bd760, 0xc0002c3080, {0xc0001c8000, 0x4, 0x4})
    /home/kilrau/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/command.go:267 +0xb7d
github.com/urfave/cli/v2.(*App).RunContext(0xc000214780, {0xe42b00, 0x13b0640}, {0xc0001c8000, 0x4, 0x4})
    /home/kilrau/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/app.go:332 +0x566
github.com/urfave/cli/v2.(*App).Run(...)
    /home/kilrau/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/app.go:309
main.main()
    /home/kilrau/GitHub/boltz-client/cmd/boltzcli/boltzcli.go:113 +0x911