BoltzExchange / boltz-web-app

Boltz Web App
https://boltz.exchange
GNU Affero General Public License v3.0
58 stars 21 forks source link

WebLN enable() should not expect an object? #229

Closed otech47 closed 1 year ago

otech47 commented 1 year ago

According to the spec at webln.guide the enable function has a return type of void

boltz.exchange has 2 instances calling window.webln.enable() and both are expecting it to return an object with a enabled field that must be truthy in order for webLN to proceed and work properly

Seems Alby as a WebLN provider is also deviating from this spec since the webln object injected by Alby has an enable function that does not have a void return type, which is probably why the logic below was written this way

Screenshot 2023-07-27 at 1 44 10 PM

Not sure if the spec should change or this implementation should change but WebLN providers who implement enable according to the spec will not be compatible with boltz.exchange due to this inconsistency

humansinstitute commented 1 year ago

Hi All - when I test this in Fedi App I'm still getting failures trying to pay via webLN is this deployed on boltz.exchange?