search

Bonandry / yaru-plus

Yaru++, an elegant and modern third-party icons theme, based on Ubuntu's Yaru
GNU General Public License v3.0
83 stars 5 forks source link

Incompatible with Kvantum/KvYaru #32

Closed ryu-ketsueki closed 3 years ago

ryu-ketsueki commented 4 years ago

I'm using this icon pack with KvYaru as theme for KDE Plasma. For both Yaru++ and Yaru++-Dark, the icons are not inverted for the toolbars. This is an issue only with Yaru++ Icon Packs, as the other icon packs such as Breeze, Qogir and others, display the icons properly on the toolbars.

This is how it is showing: https://i.postimg.cc/2yFLpF4X/Screenshot-20191024-172604.png This is how the Yaru++-Dark shows: https://i.postimg.cc/kMxbt9kF/Screenshot-20191024-172627.png This is how it is supposed to show: https://i.postimg.cc/Wbzscw6F/Screenshot-20191024-173108.png

gusbemacbe commented 4 years ago

Hello @ryu-ketsueki !

Before, Yaru++ was designed exclusively to light Ubuntu. I, as co-author and the repo's author had an agreement that Yaru++ should be expanded to be supported in many non-Ubuntu and non-GNOME distributions, non-light and mixed themes, but only the folder apps is complete. Next month I should focus on it after finishing Adwaita++ and Suru++ 30 jobs.

If you want it to be solved quickly, as you know how to do it because you showed us how you solved in the third screenshot, you are free to clone our repo, and make a PR.

ryu-ketsueki commented 4 years ago

If you want it to be solved quickly, as you know how to do it because you showed us how you solved in the third screenshot, you are free to clone our repo, and make a PR.

Sadly that was a bug with Plasma's icons. I applied Yaru++-Dark after Yaru++ while keeping Dolphin's window open, making only the icons on the toolbar change. Everything changes to the recently applied icon pack if I close and reopen the window. But I will see what I can do. It would appear that some icons are showing grey instead of black. If I learn why they are like that, I may be use it to have them turn all white.

gusbemacbe commented 4 years ago

Toolbar icons belong to {actions,status}. I would change to white colour. Apps, files and folders icons belongs to {apps,categories,mimetypes,places/16}. I would change to black colour or any colour.

Was it what you were trying to test?

I would create a new alternative icons theme as kYaru++, designed for Plasma/KDE/QT.

I doubt that the actions and status icons with white colour work in the toolbar, menu bar, bar menu of other apps.

gusbemacbe commented 4 years ago

Hello @ryu-ketsueki !

I have just added compatibility with Kvantum. It is on the branch gusbemacbe and please, usekYaru++. Please tell me if it worked with Kvantum.

ryu-ketsueki commented 4 years ago

Hello @ryu-ketsueki !

I have just added compatibility with Kvantum. It is on the branch gusbemacbe and please, usekYaru++. Please tell me if it worked with Kvantum.

There are many icons missing. I think it may be a problem with inherits. As for the icons already here, few of them are on the right colors. I tested using KvMojaveMixed, which used the mixed light/dark appearance from the original KvYaru. The new one seem to have abandoned it completely. I will see if I can find a similar one and also has the Mixed light/dark appearance as the default Yaru for Ubuntu.

Here is an image of my first test. The dock icons are icons I had set manually, so they are not defined by icon pack image

gusbemacbe commented 4 years ago

Hello @ryu-ketsueki

I'll investigate this issue.

gusbemacbe commented 4 years ago

Hi @ryu-ketsueki

I finally investigated the cause:

image

Because you did not copy Yaru++ to the icons folder. The kYaru++ depends on Yaru++.

Still I have to improve some icons because some of them are still white somewhere.

gusbemacbe commented 4 years ago

@ryu-ketsueki

I have just updated the kYaru++. Please put both Yaru++ and kYaru++ to ~/.local/share/icons.

ryu-ketsueki commented 4 years ago

The problem persists. Also, I did extract all folders that the inherits would have asked plus the Dark and Smooth ones as well. I did for the last time I tested as well, so I don't know what may be causing this. The inherits are here no problem. image

gusbemacbe commented 4 years ago

Hi @ryu-ketsueki

  1. What's your Linux distro?
  2. Did you install Qt5ct?
  3. Can you share me small dotfiles (Plasma Look and Feel themes, Latte Dock theme, plugins and icons themes)?
gusbemacbe commented 3 years ago

Since you do not answer anymore, I must close this issue.

ryu-ketsueki commented 3 years ago

I apologize, I do not have much time to invest on this, even because now KvYaru does not use a dark toolbar anymore, so this would not be necessary anymore. But from what I could tell in the last times I used Yaru++, the kYaru++ is working well.

gusbemacbe commented 3 years ago

@ryu-ketsueki, I am glad it worked.